fix: Fix slice length no longer allowing None
#17372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockbeard
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17372 +/- ##
==========================================
+ Coverage 80.72% 80.74% +0.02%
==========================================
Files 1475 1475
Lines 193383 193383
Branches 2760 2760
==========================================
+ Hits 156113 156154 +41
+ Misses 36760 36719 -41
Partials 510 510 ☔ View full report in Codecov by Sentry. |
stinodego
approved these changes
Jul 2, 2024
stinodego
changed the title
None
stinodego
changed the title
Noneslice length no longer allowing None
github-actions
bot
added
python
ritchie46
requested changes
Jul 3, 2024
| @@ -451,7 +451,7 @@ impl OptimizationRule for TypeCoercionRule { | |||
| polars_ensure!(offset_dtype.is_integer(), InvalidOperation: "offset must be integral for slice, not {}", offset_dtype); | |||
| let (_, length_dtype) = | |||
| unpack!(get_aexpr_and_type(expr_arena, length, &input_schema)); | |||
| polars_ensure!(length_dtype.is_integer(), InvalidOperation: "length must be integral for slice, not {}", length_dtype); | |||
| polars_ensure!(length_dtype.is_integer() || length_dtype.is_null(), InvalidOperation: "length must be integral for slice, not {}", length_dtype); | |||
There was a problem hiding this comment.
I think you should negate the check. !is_null.
| @@ -747,3 +747,16 @@ def test_slice_rejects_non_integral() -> None: | |||
|
|
|||
| with pytest.raises(pl.exceptions.InvalidOperationError): | |||
| df.select(pl.col("a").slice(pl.lit("1"), None)).collect() | |||
|
|
|||
|
|
|||
| def test_slice() -> None: | |||
There was a problem hiding this comment.
Can you test what you want fixed? E.g. ensure that we raise on the invalid input.
|
Ah, nevermind. I now see the issue. We want |
ritchie46
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17365