fix(rust): avoid panic when projecting solitary count into empty frame #17393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17393 +/- ##
==========================================
- Coverage 80.74% 80.73% -0.02%
==========================================
Files 1475 1475
Lines 193389 193392 +3
Branches 2760 2760
==========================================
- Hits 156146 156127 -19
- Misses 36733 36755 +22
Partials 510 510 ☔ View full report in Codecov by Sentry. |
When the schema of a frame is empty, a count expression is still valid since it does not refer to any columns. In this scenario, selecting the "last" column in the schema would previously panic, since there are none. Fix this by handling this edge case explicitly. - Closes pola-rs#16904
ritchie46
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the schema of a frame is empty, a count expression is still valid since it does not refer to any columns. In this scenario, selecting the "last" column in the schema would previously panic, since there are none. Fix this by handling this edge case explicitly.
lenfrom empty dataframe with projection_pushdown #16904