Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix from_pandas for string columns with missing values #17397

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 3, 2024

Closes #17355

Changes

  • No longer allow going through NumPy for columns of type object if the column contains missing values. The PyArrow path is used instead.

@MarcoGorelli FYI

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jul 3, 2024
@stinodego stinodego marked this pull request as ready for review July 3, 2024 12:50
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (d13efa5) to head (c7a9560).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17397      +/-   ##
==========================================
- Coverage   80.74%   80.73%   -0.01%     
==========================================
  Files        1475     1475              
  Lines      193389   193397       +8     
  Branches     2760     2760              
==========================================
+ Hits       156146   156148       +2     
- Misses      36733    36739       +6     
  Partials      510      510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1146993 into main Jul 4, 2024
17 checks passed
@ritchie46 ritchie46 deleted the fix-from-pandas-natype branch July 4, 2024 06:04
henryharbeck pushed a commit to henryharbeck/polars that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.from_pandas with columns that mix strings and NAs results in TypeError
3 participants