feat: Support hive partitioning in scan_ipc
#17434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Jul 5, 2024
|
|
||
| // Used to determine the next file to open. This guarantees the order. | ||
| let path_index = AtomicUsize::new(0); | ||
| let row_counter = RwLock::new(ConsecutiveCountState::new(self.paths.len())); |
There was a problem hiding this comment.
drive-by simplify a bit by removing these atomics - into_par_iter guarantees result ordering
nameexhaustion
commented
Jul 5, 2024
| // Used to determine the next file to open. This guarantees the order. | ||
| let path_index = AtomicUsize::new(0); | ||
| let row_counter = RwLock::new(ConsecutiveCountState::new(self.paths.len())); | ||
| let mut dfs = if let Some(mut n_rows) = self.file_options.n_rows { |
There was a problem hiding this comment.
drive-by - use sequential read if there is a row limit - this is usually what we do in other places (union, csv scan)
nameexhaustion
commented
Jul 5, 2024
nameexhaustion
changed the title
scan_ipc(hive_partitioning=True)scan_ipc(hive_partitioning=True)
github-actions
bot
added
enhancement
nameexhaustion
changed the title
scan_ipc(hive_partitioning=True)scan_ipc
nameexhaustion
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17434 +/- ##
==========================================
- Coverage 80.68% 80.63% -0.06%
==========================================
Files 1476 1477 +1
Lines 193490 193457 -33
Branches 2760 2760
==========================================
- Hits 156126 155996 -130
- Misses 36854 36951 +97
Partials 510 510 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14885