fix: Raise on oob decimal precision #17445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
stinodego
reviewed
Jul 5, 2024
cpcloud
reviewed
Jul 5, 2024
| (*precision).unwrap_or(38), | ||
| scale.unwrap_or(0), // and what else can we do here? | ||
| )), | ||
| Decimal(precision, scale) => { |
There was a problem hiding this comment.
PyArrow supports decimal256 too, is there any reason this should error as opposed to outputting a decimal256 array?
There was a problem hiding this comment.
We don't support Decimal256. It turned out the precision given wasn't supported by Polars, so we raise earlier. Therefore we would also never need to export to Decimal256.
henryharbeck
pushed a commit
to henryharbeck/polars
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17425