Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Add missing commas in python IR interchange #17518

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented Jul 9, 2024

Easy issue with "untyped" code, sorry! (cc @MarcoGorelli)

I also added myself as codeowner for the python IR subsystem: so that I get a heads up when things are changing (cc @ritchie46)

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (a5724d6) to head (7ce29d0).

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17518   +/-   ##
=======================================
  Coverage   80.47%   80.48%           
=======================================
  Files        1482     1482           
  Lines      195119   195119           
  Branches     2778     2778           
=======================================
+ Hits       157026   157033    +7     
+ Misses      37582    37575    -7     
  Partials      511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

I also added myself as codeowner for the python IR subsystem: so that I get a heads up when things are changing (cc @ritchie46)

Yes, that's a good one!

@ritchie46 ritchie46 merged commit 7b8612c into pola-rs:main Jul 9, 2024
18 checks passed
@wence-
Copy link
Collaborator Author

wence- commented Jul 9, 2024

I also added myself as codeowner for the python IR subsystem: so that I get a heads up when things are changing (cc @ritchie46)

Yes, that's a good one!

I suspect you'll need to add me with write access to the repo as well.

@wence- wence- deleted the wence/fix/pyir-temporalfunction branch July 10, 2024 09:22
@eitsupi
Copy link
Contributor

eitsupi commented Jul 11, 2024

@wence- I think the title of the pull request is wrong, it should be python, not rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants