-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly implement struct #17522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
July 10, 2024 07:16
ritchie46
changed the title
WIP: Properly implement struct
fix: Properly implement struct
Jul 11, 2024
github-actions
bot
added
fix
Bug fix
python
Related to Python Polars
and removed
title needs formatting
labels
Jul 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17522 +/- ##
==========================================
- Coverage 80.47% 80.39% -0.09%
==========================================
Files 1482 1483 +1
Lines 195119 195160 +41
Branches 2778 2778
==========================================
- Hits 157026 156900 -126
- Misses 37582 37749 +167
Partials 511 511 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix outer nullability issues and lot's of bugs relating to chunking. The struct type will now be first class citizen.
This touches a lot of code, so I am going to give this one preference in merging as conflicts are a nightmare in this.