-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Defer path expansion until collect
in file scan methods
#17532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
labels
Jul 9, 2024
stinodego
force-pushed
the
cloud-scan-fix
branch
2 times, most recently
from
July 10, 2024 10:24
f5db18e
to
9a462b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17532 +/- ##
==========================================
- Coverage 80.44% 80.43% -0.01%
==========================================
Files 1484 1484
Lines 195324 195341 +17
Branches 2778 2778
==========================================
- Hits 157133 157128 -5
- Misses 37679 37701 +22
Partials 512 512 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
July 10, 2024 11:23
ritchie46
approved these changes
Jul 11, 2024
Looks good. Can you do a rebase? |
stinodego
force-pushed
the
cloud-scan-fix
branch
from
July 11, 2024 18:20
82a6177
to
1705985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #17444
I left a TODO for delaying path expansion for
scan_csv
whenwith_column_names
is specified. This will still raise immediately rather than on collect, but it's an annoying one to fix... Can look at it in a follow-up PR.