Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defer path expansion until collect in file scan methods #17532

Merged
merged 17 commits into from
Jul 11, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 9, 2024

Ref #17444

I left a TODO for delaying path expansion for scan_csv when with_column_names is specified. This will still raise immediately rather than on collect, but it's an annoying one to fix... Can look at it in a follow-up PR.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 9, 2024
@stinodego stinodego force-pushed the cloud-scan-fix branch 2 times, most recently from f5db18e to 9a462b7 Compare July 10, 2024 10:24
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (aa2c8f1) to head (1705985).

Files Patch % Lines
crates/polars-lazy/src/scan/file_list_reader.rs 0.00% 2 Missing ⚠️
crates/polars-lazy/src/scan/ndjson.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17532      +/-   ##
==========================================
- Coverage   80.44%   80.43%   -0.01%     
==========================================
  Files        1484     1484              
  Lines      195324   195341      +17     
  Branches     2778     2778              
==========================================
- Hits       157133   157128       -5     
- Misses      37679    37701      +22     
  Partials      512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Looks good. Can you do a rebase?

@stinodego stinodego merged commit 64b45a8 into main Jul 11, 2024
27 checks passed
@stinodego stinodego deleted the cloud-scan-fix branch July 11, 2024 19:31
@c-peters c-peters added the accepted Ready for implementation label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants