Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Add/fix version-gating in some SQLAlchemy and Pandas tests #17538

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jul 10, 2024

Closes #17487.

Adds/tweaks some version-gating for a couple of tests.

  • One test should have been gated on the Pandas version, but was using the Python version to imply this instead.
  • Also, there's still a large SQLAlchemy 1.x install base (and it has been updated independently of 2.x as recently as March), so allowing tests to run with both versions is worthwhile (we still run it in a few places at work, for example, due to some otherwise incompatible drivers).

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jul 10, 2024
@alexander-beedie alexander-beedie added the test Related to the test suite label Jul 10, 2024
@alexander-beedie alexander-beedie changed the title test(python): Add/fix some version-gating in tests for alchemy/pandas test(python): Add/fix version-gating in some SQLAlchemy and Pandas tests Jul 10, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.47%. Comparing base (daf2e49) to head (84ab86f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17538      +/-   ##
==========================================
- Coverage   80.48%   80.47%   -0.01%     
==========================================
  Files        1483     1483              
  Lines      195118   195118              
  Branches     2778     2778              
==========================================
- Hits       157039   157025      -14     
- Misses      37568    37582      +14     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit aa2c8f1 into pola-rs:main Jul 11, 2024
17 checks passed
@alexander-beedie alexander-beedie deleted the misc-test-versioning branch July 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in tests when pandas<2.2 and sqlalchemy<2
2 participants