perf: Batch nested embed parquet decoding #17549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
performance
This continues on pola-rs#17542 and now also batches the actual Nesting, not only the top decoder. I did the same benchmark with `POLARS_MAX_THREADS=1` and we again see a small speedup. But I suspect that the speedup is larger for `FixedSizeList`s and `Struct`s. ``` Benchmark 1: After Optimization Time (mean ± σ): 13.306 s ± 0.018 s [User: 12.661 s, System: 0.614 s] Range (min … max): 13.263 s … 13.335 s 10 runs Benchmark 2: Before Optimization Time (mean ± σ): 14.973 s ± 0.065 s [User: 14.422 s, System: 0.517 s] Range (min … max): 14.887 s … 15.129 s 10 runs Summary After Optimization ran 1.13 ± 0.01 times faster than Before Optimization ```
coastalwhite
force-pushed
the
parquet-batch-nested
branch
from
0b157c5
to
0e2849d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on #17542 and now also batches the actual Nesting, not only the top decoder.
I did the same benchmark with
POLARS_MAX_THREADS=1and we again see a small speedup. But I suspect that the speedup is larger forFixedSizeLists andStructs.