-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to include file path for Parquet, IPC, CSV scans #17563
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17563 +/- ##
==========================================
+ Coverage 80.45% 80.46% +0.01%
==========================================
Files 1484 1484
Lines 195341 195509 +168
Branches 2778 2778
==========================================
+ Hits 157154 157310 +156
- Misses 37675 37687 +12
Partials 512 512 ☔ View full report in Codecov by Sentry. |
@@ -16,19 +16,19 @@ use crate::prelude::optimizer::predicate_pushdown::join::process_join; | |||
use crate::prelude::optimizer::predicate_pushdown::rename::process_rename; | |||
use crate::utils::{check_input_node, has_aexpr}; | |||
|
|||
pub type HiveEval<'a> = | |||
pub type ExprEval<'a> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by - rename to ExprEval as it is a generic evaluator
Nice one! Can you rebase? |
40e32bb
to
b77b7a4
Compare
rebased 👍 |
Closes #10481
This introduces an
include_file_paths
parameter, which accepts a column name to use for the column storing the file path.