fix: Fix scanning from HTTP cloud paths #17571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Jul 11, 2024
| if builder.get_config_value(key).is_none() { | ||
| let reg = Regex::new(pattern).unwrap(); | ||
| let cap = reg.captures(content)?; | ||
| let m = cap.get(1)?; | ||
| let parsed = m.as_str(); | ||
| *builder = local.with_config(*key, parsed) | ||
| *builder = std::mem::take(builder).with_config(*key, parsed); |
There was a problem hiding this comment.
Fix issue with the config key being incorrectly overwritten. If the code above using ? short circuits then the original config is reset due to mem::take.
nameexhaustion
commented
Jul 11, 2024
| futures::future::try_join_all( | ||
| (0..if first_uri.starts_with("http") { | ||
| // Object stores for http are tied to the path. | ||
| uri_list.len() |
There was a problem hiding this comment.
Fix issue where scanning a list of HTTP paths would just scan the first file N times.
nameexhaustion
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
|
I learned this today but the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17571 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 1483 1483
Lines 195171 195203 +32
Branches 2778 2778
=======================================
+ Hits 157099 157135 +36
+ Misses 37561 37557 -4
Partials 511 511 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jul 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17567