perf: Fix pathological perf issue in window-order-by #17650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
ritchie46
commented
Jul 16, 2024
| .collect::<PolarsResult<_>>()?; | ||
| // Will trigger a gather for every group, so rechunk before. | ||
| let sort_by_s = sort_by_s.rechunk(); | ||
| let groups = POOL.install(|| { |
There was a problem hiding this comment.
We forgot to launch on our thread pool, so for every group our thread pool was contending with rayon's default. This improved the single chunk query 7 times on a debug build for me.
| .par_iter() | ||
| .map(|indicator| sort_by_groups_single_by(indicator, sort_by_s, options)) | ||
| .collect::<PolarsResult<_>>()?; | ||
| // Will trigger a gather for every group, so rechunk before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17637