feat: Raise informative error message if non-IntoExpr is passed by name in *Frame.group_by #17654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17540
Although the current behaviour is technically correct, I think this is worth doing - the pandas docs have examples such as
so the many pandas users trying out Polars would now get an informative error
I did debate whether this should raise a warning instead of an error, but my
Demo:
I did debate whether it would be better to raise a warning instead...however, I really can't think of a use case for passing a list literal to
group_by
, it defeats the purpose of the operation