fix(rust): Fix type inference failure caused by double transpose #17663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteNybbler
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
ByteNybbler
changed the title
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17663 +/- ##
==========================================
- Coverage 80.70% 80.69% -0.02%
==========================================
Files 1485 1490 +5
Lines 195511 195928 +417
Branches 2782 2789 +7
==========================================
+ Hits 157788 158095 +307
- Misses 37211 37320 +109
- Partials 512 513 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances, compiling Polars failed with a type inference error involving
openssl::error::ErrorStack. It was possibly related to compiling with libssl-dev. This PR fixes that issue by removing a nasty doubletranspose. A nice side effect is that the problematic code has become a lot cleaner.