Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Raise error instead of panic in unsupported serde #17679

Merged
merged 3 commits into from
Jul 18, 2024
Merged

feat: Raise error instead of panic in unsupported serde #17679

merged 3 commits into from
Jul 18, 2024

Conversation

ragyabraham
Copy link
Contributor

A todo!() was used in the wildcard scenario for the serialize method. Replaced it with panic so that the method is useable

@ragyabraham ragyabraham mentioned this pull request Jul 17, 2024
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (e74c0d5) to head (1992559).
Report is 13 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/datatypes/any_value.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17679      +/-   ##
==========================================
- Coverage   80.71%   80.44%   -0.27%     
==========================================
  Files        1489     1498       +9     
  Lines      195652   196459     +807     
  Branches     2786     2790       +4     
==========================================
+ Hits       157917   158047     +130     
- Misses      37223    37899     +676     
- Partials      512      513       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ragyabraham ragyabraham mentioned this pull request Jul 17, 2024
Merged
2 tasks
@ritchie46
Copy link
Member

Can you ensure CI is green?

@ragyabraham
Copy link
Contributor Author

Can you ensure CI is green?

Sorry. should be done now

ritchie46
ritchie46 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ritchie46 ritchie46 changed the title replaced todo! with panic! in serialize method for anytype on wildcar… feat: Raise error instead of panic in unsupported serde Jul 18, 2024
@ritchie46 ritchie46 merged commit 05d4703 into pola-rs:main Jul 18, 2024
22 checks passed
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ragyabraham @ritchie46