Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): Correctly reference released package in optional dependencies #17691

Merged
merged 2 commits into from
Jul 24, 2024
Merged

build(python): Correctly reference released package in optional dependencies #17691

merged 2 commits into from
Jul 24, 2024

Conversation

knl
Copy link
Contributor

@knl knl commented Jul 17, 2024 •
edited
Loading

This change ensures that during the release, pyproject.toml contains the name of the released package. This way, we avoid bringing in polars package when one installs other package types (like polars-u64-idx) with optional dependencies.

Fixes #14301

build(python): Correctly reference released package in optional depen…
311c77e 
…dencies

This change ensures that during the release, `pyproject.toml` contains
the name of the released package. This way, we avoid bringing in
`polars` package when one installs other package types with optional
dependencies.

Fixes pola-rs#14301
@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels Jul 17, 2024
@knl
Copy link
Contributor Author

knl commented Jul 19, 2024 •
edited
Loading

@ritchie46 Could you please take a look at this PR? I know the title is not the most telling, but this fixes a problem when someone installs polars-u64-idx[pandas] and gets essentially polars without the 64-bit index (per linked issue).

@ritchie46
Copy link
Member

@stinodego can you take a look here?

stinodego
stinodego requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. If you address my one comment below, this should indeed work and fix the related issue. If you can push the update I'll approve this.

Still, this is a bit of a band-aid fix and I would appreciate it if we could subsequently prioritize addressing #12880 to properly fix the issue of using alternative Polars packages as dependencies.

.github/workflows/release-python.yml Show resolved Hide resolved
@knl
Copy link
Contributor Author

knl commented Jul 23, 2024

Still, this is a bit of a band-aid fix and I would appreciate it if we could subsequently prioritize addressing #12880 to properly fix the issue of using alternative Polars packages as dependencies.

I can try tackling this issue, but I can't promise it'll be done in the next 2 weeks.

@stinodego stinodego merged commit 60d3050 into pola-rs:main Jul 24, 2024
1 check passed
@stinodego
Copy link
Member

I can try tackling this issue, but I can't promise it'll be done in the next 2 weeks.

We first need to decide how to approach it. There doesn't seem to be a great way to do it as far as I can see.

@knl knl deleted the fix-optional-dependencies branch July 24, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation of polars-u64-idx["all"] fails successfully and provides polars instead
3 participants
@knl @ritchie46 @stinodego