Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Pass through missing rolling and stringfunction information in pyir #17702

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented Jul 18, 2024

We missed these when first introducing the transliteration.

Make a small breaking change as well by aligning the names of function expressions to match those that are used in the public python Expr API.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (235cad3) to head (342c545).
Report is 55 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17702      +/-   ##
==========================================
+ Coverage   80.37%   80.50%   +0.13%     
==========================================
  Files        1500     1504       +4     
  Lines      196605   197182     +577     
  Branches     2793     2806      +13     
==========================================
+ Hits       158016   158739     +723     
+ Misses      38076    37922     -154     
- Partials      513      521       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit bcb1db8 into pola-rs:main Jul 25, 2024
18 checks passed
@wence- wence- deleted the wence/fea/pyir-minor branch July 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants