feat: Cloud support for NDJSON #17717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
nameexhaustion
force-pushed
the
ndjson-cloud
branch
from
2f1f064
to
ca3a5fe
Compare
nameexhaustion
force-pushed
the
ndjson-cloud
branch
from
ca3a5fe
to
ab84f0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17717 +/- ##
==========================================
+ Coverage 80.39% 80.42% +0.03%
==========================================
Files 1501 1501
Lines 196758 196830 +72
Branches 2793 2794 +1
==========================================
+ Hits 158178 158306 +128
+ Misses 38067 38010 -57
- Partials 513 514 +1 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa,
wence- and
orlp
as code owners
nameexhaustion
commented
Jul 19, 2024
| @@ -344,7 +344,8 @@ pub(crate) fn into_py(py: Python<'_>, plan: &IR) -> PyResult<PyObject> { | |||
| #[cfg(feature = "ipc")] | |||
| FileScan::Ipc { .. } => return Err(PyNotImplementedError::new_err("ipc scan")), | |||
| #[cfg(feature = "json")] | |||
| FileScan::NDJson { options } => { | |||
| FileScan::NDJson { options, .. } => { | |||
| // TODO: Also pass cloud_options | |||
There was a problem hiding this comment.
I think this is for the GPU engine, this probably needs updates on that side as well so I've left a todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite a common format, especially in LLM datasets