Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise empty struct #17736

Merged
merged 2 commits into from
Jul 21, 2024
Merged

fix: Raise empty struct #17736

merged 2 commits into from
Jul 21, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jul 19, 2024 •
edited
Loading

fixes #17731

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (e8e68a1) to head (cb01cb6).

Files Patch % Lines
crates/polars-plan/src/dsl/functions/coerce.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17736      +/-   ##
==========================================
- Coverage   80.44%   80.42%   -0.03%     
==========================================
  Files        1502     1502              
  Lines      197048   197057       +9     
  Branches     2794     2794              
==========================================
- Hits       158514   158477      -37     
- Misses      38020    38066      +46     
  Partials      514      514

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 7d22e1e into main Jul 21, 2024
27 checks passed
@ritchie46 ritchie46 deleted the empty branch July 21, 2024 11:20
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@ritchie46 @atigbadr
fix: Raise empty struct (pola-rs#17736)
a1d519c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pl.struct with no arguments triggers a panic
1 participant
@ritchie46