Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename Unit to Plain in Parquet reader #17751

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

coastalwhite
Copy link
Collaborator

This is more like the spec.

@coastalwhite coastalwhite changed the title chore: rename Unit to Plain in Parquet reader chore: Rename Unit to Plain in Parquet reader Jul 20, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (1df3b0b) to head (695d285).

Files Patch % Lines
...arquet/src/arrow/read/deserialize/binary/nested.rs 0.00% 3 Missing ⚠️
...arrow/read/deserialize/fixed_size_binary/nested.rs 0.00% 3 Missing ⚠️
...quet/src/arrow/read/deserialize/primitive/basic.rs 40.00% 3 Missing ⚠️
...parquet/src/arrow/read/deserialize/binary/basic.rs 0.00% 2 Missing ⚠️
...quet/src/arrow/read/deserialize/binary/decoders.rs 33.33% 2 Missing ⚠️
...arquet/src/arrow/read/deserialize/binview/basic.rs 50.00% 1 Missing ⚠️
...rquet/src/arrow/read/deserialize/binview/nested.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17751   +/-   ##
=======================================
  Coverage   80.40%   80.41%           
=======================================
  Files        1502     1502           
  Lines      197041   197041           
  Branches     2794     2794           
=======================================
+ Hits       158439   158448    +9     
+ Misses      38088    38079    -9     
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 949bfe8 into pola-rs:main Jul 21, 2024
21 checks passed
@coastalwhite coastalwhite deleted the chore-parquet-unit-plain branch July 21, 2024 13:32
@c-peters c-peters added the accepted Ready for implementation label Jul 22, 2024
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants