docs(python): Improve filter documentation #17755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atigbadr
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17755 +/- ##
==========================================
+ Coverage 80.47% 80.49% +0.01%
==========================================
Files 1503 1503
Lines 197002 197002
Branches 2795 2795
==========================================
+ Hits 158537 158575 +38
+ Misses 37945 37907 -38
Partials 520 520 ☔ View full report in Codecov by Sentry. |
KDruzhkin
reviewed
Jul 22, 2024
ritchie46
reviewed
Jul 23, 2024
| the comparison of two or more columns, please note that in Polars, | ||
| any comparison involving null values will always result in null. | ||
| As a result, these rows will be filtered out. | ||
| Ensure to handle null values appropriately to avoid unintended filtering |
There was a problem hiding this comment.
I think you should mention ne_missing and eq_missing, and I'd rather see an example using those methods as those will include missing values in the comparison.
There was a problem hiding this comment.
Yeap you are right, will do and will update the example.
atigbadr
force-pushed
the
improve-func-filter-documentation
branch
from
6cff4e5
to
862e3ed
Compare
atigbadr
force-pushed
the
improve-func-filter-documentation
branch
from
862e3ed
to
aca10d7
Compare
ritchie46
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.