-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust): Allow read_csv
schema
to take unparsable types
#17765
Conversation
read_csv
schema
to take unparsable typesread_csv
schema
to take unparsable types
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17765 +/- ##
==========================================
- Coverage 80.50% 80.50% -0.01%
==========================================
Files 1504 1504
Lines 197162 197140 -22
Branches 2806 2806
==========================================
- Hits 158732 158703 -29
- Misses 37909 37916 +7
Partials 521 521 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JamesCE2001. I've left a few comments.
bfb7464
to
8a50f88
Compare
Thanks @JamesCE2001 |
Resolves #17349, also including support for
pl.Time
andpl.Categorical
.read_csv
actually already supported passing these types toschema_overrides
, but not toschema
directly. This is mostly moving that to be shared functionally (which is the cause of the ugly diff inreader.rs
) and fixing another bug I found in testing that preventedpl.Time
from being read correctly.