fix(python): Simultaneous usage of named_expr and schema in pl.struct
#17768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandroCasagrande
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17768 +/- ##
==========================================
- Coverage 80.44% 80.42% -0.02%
==========================================
Files 1502 1502
Lines 197073 197075 +2
Branches 2794 2794
==========================================
- Hits 158539 158503 -36
- Misses 38020 38058 +38
Partials 514 514 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jul 22, 2024
| def test_named_exprs() -> None: | ||
| df = pl.DataFrame({"a": 1}) | ||
| schema = {"b": pl.Int64} | ||
| res = df.select(pl.struct(schema=schema, b=pl.col("a"))) |
There was a problem hiding this comment.
res and expect seem to be the exact same query. Can you check the valid outputs via a assert res.to_dict(as_series=False) == expected
and a res.schema == expected_schema?
There was a problem hiding this comment.
Sure, I made that part more direct. Thanks @ritchie46 .
ritchie46
approved these changes
Jul 22, 2024
|
Thanks |
atigbadr
pushed a commit
to atigbadr/polars
that referenced
this pull request
Jul 23, 2024
…truct` (pola-rs#17768) Co-authored-by: Casagrande, Sandro <sandro.casagrande@techem.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16509
The fix seem very simple. I added a test that shows the (imho) expected behavior.