Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't expand HTTP paths #17774

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jul 22, 2024

Fixes #14908

If we see a http path we will just add it to the expanded paths, otherwise they could be mistaken as glob patterns due to query string parameters

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (7888d3b) to head (762dcb0).

Files Patch % Lines
crates/polars-io/src/path_utils/mod.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17774   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files        1502     1502           
  Lines      197073   197076    +3     
  Branches     2794     2794           
=======================================
+ Hits       158539   158542    +3     
  Misses      38020    38020           
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review July 22, 2024 05:32
@ritchie46
Copy link
Member

Can we add a rust test that passes the http url and confirms we don't expand it, with a comment to this issue?

@ritchie46 ritchie46 merged commit e7c672a into pola-rs:main Jul 22, 2024
21 checks passed
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@nameexhaustion nameexhaustion deleted the expand-path-query-param branch July 28, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.read_parquet cannot read signed GCS signed url on 0.20, but can on <0.19
2 participants