Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix projection pusdhown of literals without names #17778

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: Fix projection pusdhown of literals without names #17778

merged 2 commits into from
Jul 22, 2024

Conversation

ritchie46
Copy link
Member

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (7888d3b) to head (e664742).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17778      +/-   ##
==========================================
- Coverage   80.44%   80.44%   -0.01%     
==========================================
  Files        1502     1502              
  Lines      197073   197076       +3     
  Branches     2794     2794              
==========================================
- Hits       158539   158531       -8     
- Misses      38020    38031      +11     
  Partials      514      514

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 62fe50d into main Jul 22, 2024
26 checks passed
@ritchie46 ritchie46 deleted the proj branch July 22, 2024 09:22
@philiporlando philiporlando mentioned this pull request Jul 22, 2024
Closed
3 tasks
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@ritchie46 @atigbadr
fix: Fix projection pusdhown of literals without names (pola-rs#17778)
51d8909
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters