feat: Support hf:// in read_(csv|ipc|ndjson) functions
#17785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17785 +/- ##
==========================================
+ Coverage 80.47% 80.48% +0.01%
==========================================
Files 1503 1503
Lines 197115 196981 -134
Branches 2794 2795 +1
==========================================
- Hits 158628 158541 -87
+ Misses 37973 37920 -53
- Partials 514 520 +6 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
hf-read-csv
branch
from
294adc9
to
8f7dd3a
Compare
nameexhaustion
changed the title
hf:// in read_csvhf:// in read_(csv|ipc|ndjson) functions
nameexhaustion
commented
Jul 23, 2024
| # Also dispatch on FORCE_ASYNC, so that this codepath gets run | ||
| # through by our test suite during CI. | ||
| or ( | ||
| os.getenv("POLARS_FORCE_ASYNC") == "1" |
There was a problem hiding this comment.
Magical test coverage for the hf:// dispatch 😉
|
LGTM, Could you create an issue about the breaking change for the storage options. Would be great if we could simplify the |
ritchie46
approved these changes
Jul 23, 2024
atigbadr
pushed a commit
to atigbadr/polars
that referenced
this pull request
Jul 23, 2024
stinodego
reviewed
Jul 23, 2024
Issue created at #17815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CSV and IPC, only
hf://paths are dispatched to theirscan_*equivalents. They can't dispatch for all paths as it would cause a breaking change tostorage_optionsas they currently usefsspec, which uses different configuration keys. For CSV as well there is also the issue of compressed files.read_ndjsondoesn't suffer from the above issues, so I've added the full set of parameters fromscan_ndjsonand set it to always dispatch toscan_ndjson.