Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use bitflags for OptState #17788

Merged
merged 3 commits into from
Jul 22, 2024
Merged

perf: Use bitflags for OptState #17788

merged 3 commits into from
Jul 22, 2024

Conversation

ritchie46
Copy link
Member

Brings 14 bytes down to 4.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (2eb1ac2) to head (77b6c05).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-lazy/src/frame/mod.rs 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17788      +/-   ##
==========================================
- Coverage   80.47%   80.47%   -0.01%     
==========================================
  Files        1503     1503              
  Lines      197103   197064      -39     
  Branches     2794     2794              
==========================================
- Hits       158624   158582      -42     
- Misses      37965    37968       +3     
  Partials      514      514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0379385 into main Jul 22, 2024
26 checks passed
@ritchie46 ritchie46 deleted the bits branch July 22, 2024 15:07
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants