Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Make better use of typos configuration features #17800

Merged
merged 3 commits into from
Jul 23, 2024
Merged

ci: Make better use of typos configuration features #17800

merged 3 commits into from
Jul 23, 2024

Conversation

szepeviktor
Copy link
Contributor

This is how typos can be configured to prevent hiding future typos.

Found new typos 🎁

@szepeviktor
Copy link
Contributor Author

All right linter! I go half the indent.

@alexander-beedie alexander-beedie changed the title Make proper use of typos configuration features ci: Make better use of typos configuration features Jul 23, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 23, 2024
ritchie46
ritchie46 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers.

@ritchie46 ritchie46 merged commit 0cf22cb into pola-rs:main Jul 23, 2024
27 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the typos-plus branch July 23, 2024 10:26
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@szepeviktor @atigbadr
ci: Make better use of typos configuration features (pola-rs#17800)
fc2a873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @ritchie46