Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): Non-compliant Parquet list element name #17803

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix(rust): Non-compliant Parquet list element name #17803

merged 2 commits into from
Jul 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #17100.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jul 23, 2024
coastalwhite
coastalwhite commented Jul 23, 2024
View reviewed changes
crates/polars-parquet/src/arrow/write/schema.rs
Comment on lines +394 to +396
let mut f = f.clone();
f.name = "element".to_string();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual change. The rest is all pass-by changes.

@ritchie46
Copy link
Member

Can you add a python test?

@coastalwhite coastalwhite force-pushed the fix-parquet-list-field-name-17100 branch from f306219 to 498b207 Compare July 23, 2024 08:57
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (66f0026) to head (498b207).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/polars-parquet/src/arrow/write/schema.rs 85.18% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17803      +/-   ##
==========================================
- Coverage   80.47%   80.46%   -0.02%     
==========================================
  Files        1503     1503              
  Lines      197115   196956     -159     
  Branches     2794     2794              
==========================================
- Hits       158628   158477     -151     
+ Misses      37973    37965       -8     
  Partials      514      514

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f60221d into pola-rs:main Jul 23, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fix-parquet-list-field-name-17100 branch July 23, 2024 10:14
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
@coastalwhite @atigbadr
fix(rust): Non-compliant Parquet list element name (pola-rs#17803)
c368419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nameexhaustion nameexhaustion nameexhaustion left review comments

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parquet file writer uses non-compliant list element field name
3 participants
@coastalwhite @ritchie46 @nameexhaustion