-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix from_arrow
for struct type
#17839
Conversation
Thanks, can you add a test? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17839 +/- ##
==========================================
- Coverage 80.51% 80.50% -0.01%
==========================================
Files 1503 1504 +1
Lines 197038 197162 +124
Branches 2805 2806 +1
==========================================
+ Hits 158641 158723 +82
- Misses 37876 37918 +42
Partials 521 521 ☔ View full report in Codecov by Sentry. |
I added a unit test for both chunked and regular arrays and updated the existing unit test for |
anything else that I should include in the PR @ritchie46? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @delsner
I ran into this same issue and while this fix does work, I was wondering if the pa.StructType can ever have a The only type I can see with a |
Motivation
Using an arrow
struct
column type in an arrow table causesfrom_arrow
to fail with the following error message:Changes
arrow_to_pydf
function to first check for thenum_chunks
attribute