docs(python): Reword "how" param docstring entry for 'semi' and 'anti' join types for clarity
#17843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implicit-apparatus
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
requested changes
Jul 24, 2024
alexander-beedie
changed the title
github-actions
bot
added
documentation
alexander-beedie
changed the title
join types for clarity
implicit-apparatus
force-pushed
the
join_documentation_reword
branch
from
9f4a9fa
to
ea5e50a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17843 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 1504 1504
Lines 197156 197162 +6
Branches 2806 2806
=======================================
+ Hits 158704 158710 +6
Misses 37931 37931
Partials 521 521 ☔ View full report in Codecov by Sentry. |
alexander-beedie
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #17782
I hope this slight rewording makes it clearer that 'semi' and 'anti' do not return rows of the right table.