fix: Properly write nest-nulled values in Parquet #17845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
coastalwhite
changed the title
github-actions
bot
added
fix
coastalwhite
force-pushed
the
fix-parquet-nested-nullability-17805
branch
from
57ae3b3
to
c389490
Compare
Fixes pola-rs#17805. This fixes an issue on the Parquet writer where values that would be valid in the primitive array but invalid at a higher nesting level would still be written. This could for example be true when do `x = (x == "") ? [ x ] : None`. In this case, the empty string might still be valid but the above list is not valid anymore. This is solved by walking through the structure and propagating the nulls to the lower levels in the parquet writer.
coastalwhite
force-pushed
the
fix-parquet-nested-nullability-17805
branch
from
c389490
to
dee3c87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17845 +/- ##
==========================================
+ Coverage 80.50% 80.52% +0.02%
==========================================
Files 1504 1505 +1
Lines 197162 197387 +225
Branches 2806 2807 +1
==========================================
+ Hits 158721 158942 +221
- Misses 37920 37923 +3
- Partials 521 522 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17805.
This fixes an issue in the Parquet writer where values that would be valid in the primitive array but invalid at a higher nesting level would still be written. This could for example be true when do
x = (x == "") ? [ x ] : None. In this case, the empty string might still be valid but the above list is not valid anymore.This is solved by walking through the structure and propagating the nulls to the lower levels in the parquet writer.