fix: Respect glob=False for cloud reads
#17860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Jul 25, 2024
| pub fn _limit_path_len_io_err(path: &Path, err: io::Error) -> PolarsError { | ||
| let path = path.to_string_lossy(); | ||
| let msg = if path.len() > 88 { | ||
| let msg = if path.len() > 88 && !verbose() { |
There was a problem hiding this comment.
drive-by QOL - print the full path if POLARS_VERBOSE is set
nameexhaustion
commented
Jul 25, 2024
| ], | ||
| ) | ||
| @pytest.mark.parametrize("char", ["[", "*", "?"]) | ||
| def test_no_glob( |
There was a problem hiding this comment.
consolidated all the tests here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17860 +/- ##
==========================================
+ Coverage 80.48% 80.56% +0.08%
==========================================
Files 1507 1495 -12
Lines 197610 197006 -604
Branches 2813 2813
==========================================
- Hits 159040 158720 -320
+ Misses 38049 37765 -284
Partials 521 521 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17822