Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove HybridRLE iter / batch nested parquet decoding #17889

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

coastalwhite
Copy link
Collaborator

This PR again removes a lot of unused code and finally fully removes the
HybridRleDecoder Iterator implementation. This is done by batching the work
done with nested decoders.

This also solves a small bug that existed for nested boolean values with a lot
of nulls.

This PR again removes a lot of unused code and finally fully removes the
HybridRleDecoder Iterator implementation. This is done by batching the work
done with nested decoders.

This also solves a small bug that existed for nested boolean values with a lot
of nulls.
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 72 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (826882d) to head (03fa6d0).
Report is 4 commits behind head on main.

Files Patch % Lines
...parquet/src/arrow/read/deserialize/binary/basic.rs 0.00% 56 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 48.00% 13 Missing ⚠️
...parquet/src/arrow/read/deserialize/nested_utils.rs 98.77% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17889      +/-   ##
==========================================
- Coverage   80.55%   80.55%   -0.01%     
==========================================
  Files        1495     1491       -4     
  Lines      197006   196733     -273     
  Branches     2813     2813              
==========================================
- Hits       158703   158475     -228     
+ Misses      37782    37737      -45     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cb108bd into pola-rs:main Jul 26, 2024
21 checks passed
@coastalwhite coastalwhite deleted the refactor-batch-nested-decoder branch July 26, 2024 12:39
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants