Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken typos command in make pre-commit for py-polars folder #17897

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 26, 2024

The typos command did not correctly respect the .gitignore file in the parent directory, so it threw lots of errors on irrelevant files. So I'm just running it from the root to address the issue.

@orlp FYI

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jul 26, 2024
@stinodego stinodego marked this pull request as ready for review July 26, 2024 19:27
@stinodego stinodego merged commit 2473807 into main Jul 26, 2024
12 checks passed
@stinodego stinodego deleted the typos-update branch July 26, 2024 20:27
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants