chore: Remove apply_generic, use unary_elementwise #17902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
github-actions
bot
added
internal
MarcoGorelli
force-pushed
the
remove-unary
branch
from
b2eb42a
to
35ba5fc
Compare
MarcoGorelli
commented
Jul 27, 2024
Comment on lines
77
to
81
| if ca.null_count == 0 { | ||
| let iter = ca | ||
| .downcast_iter() | ||
| .map(|arr| arr.values_iter().map(|x| op(Some(x))).collect_arr()); | ||
| ChunkedArray::from_chunk_iter(ca.name(), iter) |
There was a problem hiding this comment.
porting this over from apply_generic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17902 +/- ##
==========================================
- Coverage 80.35% 80.33% -0.02%
==========================================
Files 1492 1492
Lines 196330 196301 -29
Branches 2813 2813
==========================================
- Hits 157764 157705 -59
- Misses 38045 38075 +30
Partials 521 521 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jul 30, 2024
| .downcast_iter() | ||
| .map(|arr| arr.iter().map(&mut op).collect_arr()); | ||
| ChunkedArray::from_chunk_iter(ca.name(), iter) | ||
| if ca.null_count == 0 { |
There was a problem hiding this comment.
can this use has_nulls. We want to optimize this check later.
MarcoGorelli
force-pushed
the
remove-unary
branch
from
35ba5fc
to
2a6d253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was talking about yesterday
It seems to me that
apply_genericandunary_elementwiseoverlap? There's an extra little fastpath in the first one for when there's no nulls (which I ported over), but other than that, is it necessary to have both?