Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add general filters in Parquet #17910

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Jul 27, 2024

This PR gain removes a lot of duplicated code and removes a large polymorphisation item.

The main goal was to more generalized filters, and those should now be in place. My goal now is to use them from the parquet reader.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jul 27, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 67.62246% with 271 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (6e4b481) to head (d50242e).

Files Patch % Lines
...olars-parquet/src/arrow/read/deserialize/simple.rs 61.88% 85 Missing ⚠️
...olars-parquet/src/arrow/read/deserialize/nested.rs 39.25% 65 Missing ⚠️
...parquet/src/arrow/read/deserialize/nested_utils.rs 71.50% 53 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 49.18% 31 Missing ⚠️
...parquet/src/arrow/read/deserialize/utils/filter.rs 71.42% 12 Missing ⚠️
...tes/polars-parquet/src/parquet/read/compression.rs 78.94% 8 Missing ⚠️
...tes/polars-parquet/src/parquet/read/page/reader.rs 87.80% 5 Missing ⚠️
...parquet/src/arrow/read/deserialize/binary/basic.rs 0.00% 4 Missing ⚠️
...et/src/arrow/read/deserialize/fixed_size_binary.rs 66.66% 2 Missing ⚠️
.../polars-parquet/src/arrow/read/deserialize/null.rs 90.90% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17910      +/-   ##
==========================================
- Coverage   80.46%   80.33%   -0.14%     
==========================================
  Files        1493     1492       -1     
  Lines      196477   196330     -147     
  Branches     2813     2813              
==========================================
- Hits       158099   157724     -375     
- Misses      37857    38085     +228     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 82b6388 into pola-rs:main Jul 29, 2024
21 checks passed
@coastalwhite coastalwhite deleted the parquet-filters branch July 29, 2024 14:02
@c-peters c-peters added the accepted Ready for implementation label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants