-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for binary size
method to Expr and Series "bin" namespace
#17924
Conversation
1706c12
to
461f1d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17924 +/- ##
==========================================
+ Coverage 80.34% 80.35% +0.01%
==========================================
Files 1492 1495 +3
Lines 196303 196480 +177
Branches 2813 2817 +4
==========================================
+ Hits 157724 157891 +167
- Misses 38058 38069 +11
+ Partials 521 520 -1 ☔ View full report in Codecov by Sentry. |
Seems useful to have. Just commenting to point out that the equivalent method in the |
I thought about it, but binary blobs are likely to be payloads of some kind, which you would more naturally think of as having a certain size, rather than a length (and you definitely wouldn't think of length in terms of kilo/mega/giga bytes) ;) eg: this is a bit odd - "how long is my image data?" vs: "what size is my image data?" |
Looks like I might be missing a feature gate somewhere - will have a look after lunch 🤔 Update: found & fixed. |
6e38a9a
to
90ff20e
Compare
Rebased 👌 |
Feature
We didn't have a way to get the size of Binary elements; this PR adds
size
to the "bin" namespace forExpr
andSeries
.Behaves the same as the frame-level
estimated_size
, where we return integer bytes in Rust, and allow Python to additionally supply a size unit to get a scaled float value in kb/mb/gb, if desired.Example
Get the size of individual binary elements:
Check size of the total binary payload for the frame: