Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for parsing parquet file where the time zone is stored as lowercase "utc" #17925

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #17547

@MarcoGorelli MarcoGorelli changed the title feat: allow for parsing parquet file where the time zone is stored as lowercase "utc" feat: Allow for parsing parquet file where the time zone is stored as lowercase "utc" Jul 29, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (f7cac6b) to head (a77fb09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17925      +/-   ##
==========================================
+ Coverage   80.48%   80.50%   +0.01%     
==========================================
  Files        1493     1493              
  Lines      196477   196477              
  Branches     2813     2813              
==========================================
+ Hits       158137   158164      +27     
+ Misses      37819    37792      -27     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 29, 2024 08:30
@ritchie46 ritchie46 merged commit 6e4b481 into pola-rs:main Jul 29, 2024
27 of 28 checks passed
@sm-Fifteen
Copy link

Does the unit test fail if either the Some("UTC") or Some("utc") match is removed? I recall that Parquet does not actually store time zone specifiers, only UTC-normalized timestamps, and the weird timezone specifier in the Arrow dataframe was being added by Arrow2.

So where does this lowercase "utc" come from? If it does not come from the Parquet file, then this test case probably does not test for what you think it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unable to parse time zone" when reading a Parquet File with Time Zone "utc" (lower case)
3 participants