Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix glob resolution for Hugging Face #17958

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jul 31, 2024

Fixes #17957

It seems I got too used to only passing the directory paths now, so I forgot how to do glob expansion 😆

todo: see if we can revert huggingface/dataset-viewer#3006 after the next release

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 31, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review July 31, 2024 12:00
@ritchie46 ritchie46 merged commit 6065465 into pola-rs:main Jul 31, 2024
25 checks passed
@nameexhaustion nameexhaustion deleted the hf-glob branch August 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glob resolution not working for Hugging Face paths
2 participants