Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nested SQL join support #18006

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

wangxiaoying
Copy link
Contributor

fix #18005

@wangxiaoying wangxiaoying changed the title Add nested join support bug: Add nested join support Aug 1, 2024
@wangxiaoying wangxiaoying changed the title bug: Add nested join support fix(rust): Add nested join support Aug 1, 2024
@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars and removed title needs formatting labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (316d621) to head (44fa2fd).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-sql/src/context.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18006      +/-   ##
==========================================
+ Coverage   80.48%   80.50%   +0.01%     
==========================================
  Files        1496     1496              
  Lines      196646   196734      +88     
  Branches     2817     2817              
==========================================
+ Hits       158274   158378     +104     
+ Misses      37851    37835      -16     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title fix(rust): Add nested join support feat: Add nested SQL join support Aug 2, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Aug 2, 2024
@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 04ac815 into pola-rs:main Aug 2, 2024
28 of 29 checks passed
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedJoin is not implemented
3 participants