Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typos and remove trailing whitespace #18024

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

ember91
Copy link
Contributor

@ember91 ember91 commented Aug 2, 2024

No description provided.

@ember91 ember91 changed the title Fix typos and remove trailing whitespace fix: typos and remove trailing whitespace Aug 2, 2024
@ember91 ember91 changed the title fix: typos and remove trailing whitespace fix: Fix typos and remove trailing whitespace Aug 2, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (d5265d3) to head (9149999).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18024      +/-   ##
==========================================
+ Coverage   80.49%   80.51%   +0.01%     
==========================================
  Files        1496     1496              
  Lines      196786   196786              
  Branches     2817     2817              
==========================================
+ Hits       158407   158443      +36     
+ Misses      37858    37822      -36     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -61,7 +61,7 @@ Note that ``Config`` supports setting context-scoped options. These options
are valid *only* during scope lifetime, and are reset to their initial values
(whatever they were before entering the new context) on scope exit.

You can take advantage of this by initialising a``Config`` instance and then
You can take advantage of this by initialising a``Config`` instance and then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a space in `a``Config`` (I think the one you deleted needed to be moved after the a).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. My mistake. Fixed it.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ritchie46 ritchie46 merged commit 0f78c9e into pola-rs:main Aug 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants