fix: Fix CloudWriter to use buffer before making requests
#18027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue started after the bump of `ObjectStore` to v0.10. Before that, ObjectStore was doing an internal buffer. The implementation is using `ObjectStore::BufWriter`, that is going to perform a "put" request if the size of data is below the "capacity". Otherwise it is going to do a "put multipart" instead. Fixes pola-rs#17172
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18027 +/- ##
==========================================
+ Coverage 80.49% 80.50% +0.01%
==========================================
Files 1496 1496
Lines 196786 196786
Branches 2817 2817
==========================================
+ Hits 158407 158427 +20
+ Misses 37858 37838 -20
Partials 521 521 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Aug 4, 2024
| @@ -7,4 +7,6 @@ edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| aws-creds = "0.36.0" | |||
| polars = { path = "../../crates/polars", features = ["lazy", "aws", "parquet", "cloud_write"] } | |||
| polars = { path = "../../crates/polars", features = ["lazy", "aws", "parquet", "cloud_write", "streaming"] } | |||
There was a problem hiding this comment.
Because I'm getting this error when streaming is disabled:
thread 'main' panicked at /Users/philip/polars/crates/polars-lazy/src/frame/mod.rs:625:17:
activate feature 'streaming'
|
Alright. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue started after the bump of
ObjectStoreto v0.10. Before that, ObjectStore was doing an internal buffer.The implementation is using
ObjectStore::BufWriter, that is going to perform a "put" request if the size of data is below the "capacity". Otherwise it is going to do a "put multipart" instead.Fixes #17172