Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Integer fast path Parquet dict encoding #18030

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

coastalwhite
Copy link
Collaborator

This adds a fast path for the slowest part of parquet writing which is (attemping) the dictionary encoding. Normally this involves a lot of hashing which is quite slow. With this PR, it will first look at the minimum and maximum values for integers. If these are sufficiently close together, we create the dictionary using those values.

This adds a fast path for the slowest part of parquet writing which is
(attemping) the dictionary encoding. Normally this involves a lot of hashing
which is quite slow. With this PR, it will first look at the minimum and
maximum values for integers. If these are sufficiently close together, we
create the dictionary using those values.
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 3, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (d5265d3) to head (2294531).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18030      +/-   ##
==========================================
+ Coverage   80.49%   80.51%   +0.01%     
==========================================
  Files        1496     1496              
  Lines      196786   196867      +81     
  Branches     2817     2817              
==========================================
+ Hits       158407   158501      +94     
+ Misses      37858    37845      -13     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d84b3fd into pola-rs:main Aug 4, 2024
21 checks passed
@coastalwhite coastalwhite deleted the perf-parquet-write-dictionary branch August 4, 2024 09:25
@c-peters c-peters added the accepted Ready for implementation label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants