Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix drop selector #18034

Merged
merged 1 commit into from
Aug 4, 2024
Merged

fix(python): Fix drop selector #18034

merged 1 commit into from
Aug 4, 2024

Conversation

ritchie46
Copy link
Member

fixes #18016

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Aug 4, 2024
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 4, 2024

Beat me to it 😆👍
I'll see if I can remove/clean-up some other uses of expand_selector this week.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (d5265d3) to head (660a144).
Report is 9 commits behind head on main.

Files Patch % Lines
...polars-plan/src/plans/conversion/expr_expansion.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18034      +/-   ##
==========================================
- Coverage   80.49%   80.45%   -0.05%     
==========================================
  Files        1496     1496              
  Lines      196786   197164     +378     
  Branches     2817     2820       +3     
==========================================
+ Hits       158407   158632     +225     
- Misses      37858    38010     +152     
- Partials      521      522       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member Author

Beat me to it 😆👍

😎

I'll see if I can remove/clean-up some other uses of expand_selector this week.

Nice. It should speed up query building for the power users. :)

@ritchie46 ritchie46 merged commit 9aa91a7 into main Aug 4, 2024
26 of 27 checks passed
@ritchie46 ritchie46 deleted the selector branch August 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.drop(cs.ends_with()) returning ColumnNotFoundError when columns exist in 1.4.0 (worked in 1.3.0)
2 participants