Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subtraction with overflow on negative slice offset in Parquet #18036

Merged
merged 2 commits into from
Aug 4, 2024
Merged

fix: Subtraction with overflow on negative slice offset in Parquet #18036

merged 2 commits into from
Aug 4, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #18035

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 4, 2024
nameexhaustion
nameexhaustion commented Aug 4, 2024
View reviewed changes
crates/polars-mem-engine/src/executors/scan/parquet.rs
first_file_idx = path_idx;
break;
}
}

let start = cum_rows - n_from_end;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😝

@ritchie46
Copy link
Member

Alright. Can we undraft. I want to do a patch release anyway. :)

@nameexhaustion nameexhaustion marked this pull request as ready for review August 4, 2024 10:02
@ritchie46 ritchie46 merged commit 55fc85a into pola-rs:main Aug 4, 2024
25 of 26 checks passed
@nameexhaustion nameexhaustion deleted the slice branch August 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attempt to subtract with overflow on negative slice in Parquet
2 participants
@nameexhaustion @ritchie46