fix(python): When setting write_excel
column totals, don't forget to include any row-total cols
#18042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
column_totals=True
we should account for any columns created viarow_totals
(we used to1, and it seems this went missing somewhere in a refactor).Also:
row_totals
column(s) dtype (int/float) should be determined by the constant columns; if all are int, the total should also be int, not float.Example
Output:
Footnotes
https://github.com/pola-rs/polars/pull/7751 ↩