fix: Panic reading multiple CSV files from cloud #18056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Aug 6, 2024
| @@ -95,7 +95,7 @@ pub fn init_entries_from_uri_list( | |||
| let cloud_path = object_path_from_str(&prefix)?; | |||
|
|
|||
| let object_store = | |||
| object_stores[std::cmp::min(i, object_stores.len())].clone(); | |||
| object_stores[std::cmp::min(i, object_stores.len() - 1)].clone(); | |||
There was a problem hiding this comment.
silly mistake 😅
we unfortunately can't add this to our test suite because it needs a real bucket
There was a problem hiding this comment.
@nameexhaustion Would it make sense to add a test which uses Azurite (using docker) or similar to test reading from "the cloud"? https://github.com/Azure/Azurite
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18056 +/- ##
==========================================
- Coverage 80.39% 80.37% -0.02%
==========================================
Files 1496 1496
Lines 197480 197480
Branches 2820 2820
==========================================
- Hits 158764 158728 -36
- Misses 38194 38230 +36
Partials 522 522 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18053