fix: Properly write Parquet for sliced lists #18073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18073 +/- ##
==========================================
- Coverage 80.37% 80.36% -0.01%
==========================================
Files 1496 1496
Lines 197542 197555 +13
Branches 2820 2820
==========================================
- Hits 158771 158770 -1
- Misses 38249 38263 +14
Partials 522 522 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Aug 7, 2024
| let validity = validity.freeze(); | ||
|
|
||
| array_stack.push_front((array.values().as_ref(), BitmapState::SomeSet(validity))); | ||
| debug_assert_eq!(validity.len(), array.values().len()); | ||
| array_stack.push((array.values().as_ref(), BitmapState::SomeSet(validity))); |
There was a problem hiding this comment.
Instead of extending the bitmap, can't we slice the values with the offsets start/end? Then we serialize the minimal amount of data.
There was a problem hiding this comment.
I tried this first and it sadly does not work. It would require changing a significant part of the Parquet writing code.
Most of the code there assumes that it is being handed the whole array and it can slice it up itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small fix for what was a quite nasty bug.
Fixes #18069.